Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to resolve workbox warning #1648

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Try to resolve workbox warning #1648

merged 1 commit into from
Sep 10, 2018

Conversation

awarecan
Copy link
Contributor

@awarecan awarecan commented Sep 9, 2018

Clean up glob related setting in WorkboxPlugin.InjectManifest.

templateUrls accepts both string and Array, it will do glob if value is Array. I don't think we need that.

@ghost ghost assigned awarecan Sep 9, 2018
@ghost ghost added the in progress label Sep 9, 2018
balloob
balloob approved these changes Sep 10, 2018
View reviewed changes
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and looks good.

@balloob balloob merged commit 4790590 into home-assistant:master Sep 10, 2018
@ghost ghost removed the in progress label Sep 10, 2018
@awarecan awarecan deleted the resolve-workbox-warning branch March 16, 2019 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees

@awarecan awarecan

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awarecan @balloob @homeassistant