ZWave Panel Updates #1647
Merged
ZWave Panel Updates #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshot with the new Node Information button and entity_id in the "Entities of this node" dropdown: |
|
I like it! Very good change 👍 |
balloob
reviewed
Sep 8, 2018
| @@ -563,6 +557,11 @@ class HaConfigZwave extends LocalizeMixin(PolymerElement) { | |||
| }; | |||
| } | |||
|
|
|||
| nodeMoreInfo(ev) { | |||
There was a problem hiding this comment.
Can you prefix private methods with _
balloob
reviewed
Sep 8, 2018
| @@ -563,6 +557,11 @@ class HaConfigZwave extends LocalizeMixin(PolymerElement) { | |||
| }; | |||
| } | |||
|
|
|||
| nodeMoreInfo(ev) { | |||
| ev.preventDefault(); | |||
There was a problem hiding this comment.
I don't think that this is necessary?
There was a problem hiding this comment.
I originally copied from the more-info code in dev-states, but tested it without this line and it looks like it still works, so I'll remove it.
balloob
reviewed
Sep 8, 2018
| @@ -563,6 +557,11 @@ class HaConfigZwave extends LocalizeMixin(PolymerElement) { | |||
| }; | |||
| } | |||
|
|
|||
| nodeMoreInfo(ev) { | |||
| ev.preventDefault(); | |||
| this.fire('hass-more-info', { entityId: this.nodes[this.selectedNode].entity_id }); | |||
There was a problem hiding this comment.
You'll need to include the EventsMixin to get this.fire
|
got a little commit-push happy with that last commit. got a couple things to fix still. |
|
Should be good to review again. |
balloob
approved these changes
Sep 10, 2018
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 updates: