Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zwave-js-server-python to 0.50.1 #94760

Merged
merged 12 commits into from
Aug 10, 2023
Merged

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Jun 17, 2023

Proposed change

Changelog:

In addition to all of the items listed in zwave-js/zwave-js-server#956 the logic in the lib for configuration_value_type has changed to include a new type BOOLEAN, so the discovery logic had to be updated as well.

Should be merged along with home-assistant/frontend#17529

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

homeassistant/components/zwave_js/triggers/event.py Outdated Show resolved Hide resolved
tests/components/zwave_js/conftest.py Outdated Show resolved Hide resolved
tests/components/zwave_js/test_climate.py Outdated Show resolved Hide resolved
@raman325 raman325 changed the title Bump zwave-js-server-python to 0.50.0 Bump zwave-js-server-python to 0.50.1 Aug 10, 2023
@raman325 raman325 marked this pull request as ready for review August 10, 2023 02:49
@raman325 raman325 requested a review from a team as a code owner August 10, 2023 02:49
@raman325 raman325 merged commit 5d3d66e into home-assistant:dev Aug 10, 2023
@raman325 raman325 deleted the bump branch August 10, 2023 05:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants