Airtouch4 integration

[samsinnamon]

Proposed change

Adds integration with AirTouch 4 smart AC Controllers. This has been discussed in a few forum posts: https://community.home-assistant.io/t/airtouch-4-integration-aus/233295/ and https://community.home-assistant.io/t/polyaire-air-touch-2-or-3/19650/21

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
should be configured by the config flow, which just takes an ip address of a local AirTouch 4 controller

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Airtouch4 integration home-assistant.io#15717
• Brands pull request: logos for airtouch 4 integration brands#2038

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[cmroche]

LGTM

[samsinnamon]

@cmroche thanks for reviewing this. Is there anything that I need to do to move this to the next stage or is it just a case of waiting? (sorry if that's a dumb question, first open source PR)

[noobydp]

Howdy everyone, any chance we can get this finalised soon?
Thanks :)

[samsinnamon]

Howdy everyone, any chance we can get this finalised soon?
Thanks :)

Hi @noobydp, any idea of who needs to be contacted to move this forward? I've been waiting for any feedback or someone to move it forward, but have heard nothing since last year

[noobydp]

Howdy everyone, any chance we can get this finalised soon?
Thanks :)

Hi @noobydp, any idea of who needs to be contacted to move this forward? I've been waiting for any feedback or someone to move it forward, but have heard nothing since last year

Sorry I dont know, I'm just an innocent bystander :P
@cgarwood are you able to help?

[samsinnamon]

Howdy everyone, any chance we can get this finalised soon?
Thanks :)

Hi @noobydp, any idea of who needs to be contacted to move this forward? I've been waiting for any feedback or someone to move it forward, but have heard nothing since last year

Sorry I dont know, I'm just an innocent bystander :P
@cgarwood are you able to help?

@frenck sorry to tag you but you were really quick on the documentation PRs - are you able to give us any guidance on how to get this integration moved forward? Seems like it has been parked for months and I'm not really sure what to do. There's a bunch of people really keen for it, and we'd all like to work on adding improvements!

[iMicknl]

I had a look at your code and had the following remarks. Hopefully it is helpful.

[samsinnamon]

I had a look at your code and had the following remarks. Hopefully it is helpful.

@iMicknl thank you greatly for taking the time to look through this PR and give it a review - I have attempted to address all the things you raised (and have also merged in some minor tweaks to the behaviour/bug fixes requested by the community members who have been testing the integration) - let me know if there is anything else that needs changing :)

[samsinnamon]

@MartinHjelmare thanks very much for all your work reviewing this PR, really appreciate it - hopefully 3rd time's the charm! Please let me know if anything else is needed :)

[salty2011]

@LonePurpleWolf just an FYI the manifest.json is missing a version tag. In the lastest Home Assistant version this appear to prevent the integration from loading as a result.

As a test I added a version tag into the manifest and restarted HA and this then allowed the integration to load correctly in the lastest version of HA

[samsinnamon]

@LonePurpleWolf just an FYI the manifest.json is missing a version tag. In the lastest Home Assistant version this appear to prevent the integration from loading as a result.

As a test I added a version tag into the manifest and restarted HA and this then allowed the integration to load correctly in the lastest version of HA

@salty2011 do you have a reference for this? I could just be looking in the wrong place but I can't find any other integrations with a version tag - I know that custom integrations required a version tag https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes/ - if you're trying to use this integration by manually adding it as a custom integration that is outside the scope of this PR as discussed here https://community.home-assistant.io/t/airtouch-4-integration-aus/233295/76 (and is mostly a workaround for the fact this PR has been waiting 6 months) - if not, please let me know where I need to put a versions tag

Thanks!

[frenck]

This is a core integration addition, core integrations don't need a version tag. That comment is incorrect.

[salty2011]

@LonePurpleWolf @frenck ,apologies wasnt aware that core integration didn't require the tag. Just something I came across while trying to manually test the integration.

Aside from that, appear to be working well

[frenck]

@LonePurpleWolf Quick scan over this PR (sorry first time for me looking at this code), it looks pretty nice at first glance!

So, let's get this train choo choo-ing 🚂

I think it is best if you'd rebased this PR onto the latest dev branch before doing anything at this point. After that, see if we can get the builds fixed.

At that point, I think we can do some minor upgrades/changes that reduce the code a bit, since, after the rebase, this PR will have access to some nice helpers that allow for that.

If you have any questions, please let me know, I'm happy to help.

../Frenck

[samsinnamon]

Hi @frenck thanks very much for taking a look! I have (hopefully) rebased onto more recent code, and also hoping that the builds might get a bit further this time (made a slight change to the external library). Let me know if theres things you think should be changed to use new helpers (not too sure what is available sorry)

[samsinnamon]

@MartinHjelmare @frenck hoping I've addressed the stuff you guys raised in the last round of code review - thanks for all the suggestions!

[MartinHjelmare]

Looks good!