Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify_ssl option to Splunk component #19112

Merged
merged 4 commits into from
Dec 27, 2018
Merged

Add verify_ssl option to Splunk component #19112

merged 4 commits into from
Dec 27, 2018

Conversation

FieldofClay
Copy link
Contributor

@FieldofClay FieldofClay commented Dec 8, 2018

Description:

Adds the verify_ssl option to the Splunk component. Defaults to True.

Related issue: fixes #11151

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#7770

Example entry for configuration.yaml:

splunk:
  token: df881b2b-579d-47ef-8458-0e1111111115
  host: 192.168.1.2
  ssl: True
  verify_ssl: False

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@fabaff
Copy link
Member

fabaff commented Dec 9, 2018

You need to update the tests as well.

@fabaff fabaff changed the title add verify_ssl option to Splunk component Add verify_ssl option to Splunk component Dec 12, 2018
@ghost ghost assigned fabaff Dec 27, 2018
@fabaff fabaff merged commit bf8b201 into home-assistant:dev Dec 27, 2018
@ghost ghost removed the in progress label Dec 27, 2018
@balloob balloob mentioned this pull request Jan 10, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
* added verify_ssl option to Splunk component

* update Splunk tests

* fix typo in Splunk tests

* Update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use Splunk integration with SSL enabled HEC when using Splunk's self-signed certificate
3 participants