Fix Météo-France setup in non French cities (because of failed next rain sensor) #134782
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @hacf-fr, @oncleben31, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Tested with following cities:
|
|
Pipe only fail because of coverage diff |
joostlek
requested changes
Jan 6, 2025
| @@ -83,7 +84,13 @@ async def _async_update_data_alert() -> CurrentPhenomenons: | |||
| update_method=_async_update_data_rain, | |||
| update_interval=SCAN_INTERVAL_RAIN, | |||
| ) | |||
| await coordinator_rain.async_config_entry_first_refresh() | |||
| try: | |||
| await coordinator_rain._async_refresh(log_failures=False) # noqa: SLF001 | |||
There was a problem hiding this comment.
why do we use _async_refresh? And not a public function?
There was a problem hiding this comment.
As written in the description: to only warn but not raise an error.
Otherwise the user will both have an error and a warn.
Because async_refresh log_failures=True !
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Test if the next rain is available for a configured location/city before adding it.
Only warn if no available, no error.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: