Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pyasn1 until fixed #125712

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Pin pyasn1 until fixed #125712

merged 2 commits into from
Sep 11, 2024

Conversation

hunterjm
Copy link
Member

@hunterjm hunterjm commented Sep 11, 2024

Proposed change

pyasn1.compat.octets was removed in pyasn1 0.6.1 and breaks some integrations and tests that import it directly
See:
pyasn1/pyasn1#60
lextudio/pysnmp#114

Also failing on split tests for new runs:
https://github.com/home-assistant/core/actions/runs/10803894867/job/29969410658

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@hunterjm hunterjm requested a review from a team as a code owner September 11, 2024 03:56
@hunterjm hunterjm mentioned this pull request Sep 11, 2024
19 tasks
@MartinHjelmare MartinHjelmare changed the title pin pyasn1 until fixed Pin pyasn1 until fixed Sep 11, 2024
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 74834b2 into home-assistant:dev Sep 11, 2024
44 checks passed
@hunterjm hunterjm deleted the pyasn1_fix branch September 11, 2024 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@frenck frenck added this to the 2024.9.2 milestone Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants