Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Schlage removed locks #123627

Merged
merged 6 commits into from
Sep 8, 2024
Merged

Fix Schlage removed locks #123627

merged 6 commits into from
Sep 8, 2024

Conversation

dknowles2
Copy link
Contributor

Proposed change

Fix some bugs when a lock is no longer returned by the Schlage API (e.g. the user removed it via the Schlage app)

This was forked off from #123418 as requested in the review.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Schlage: Fix bugs when a lock is no longer returned by the API Fix Schlage removed locks Aug 16, 2024
@home-assistant home-assistant bot marked this pull request as draft August 18, 2024 13:49
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dknowles2 dknowles2 requested a review from joostlek August 30, 2024 13:16
@dknowles2 dknowles2 marked this pull request as ready for review August 30, 2024 13:16
@joostlek
Copy link
Member

Sent you a message on Discord

@joostlek joostlek marked this pull request as draft August 30, 2024 13:56
@dknowles2 dknowles2 marked this pull request as ready for review August 31, 2024 15:56
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on discord, I think it might be better to render the lock as unknown at times we don't get full data for a lock

@home-assistant home-assistant bot marked this pull request as draft September 8, 2024 10:25
@dknowles2 dknowles2 marked this pull request as ready for review September 8, 2024 14:54
@home-assistant home-assistant bot requested a review from joostlek September 8, 2024 14:54
@joostlek joostlek added this to the 2024.9.2 milestone Sep 8, 2024
@joostlek joostlek merged commit 5405279 into home-assistant:dev Sep 8, 2024
29 checks passed
@dknowles2 dknowles2 deleted the schlage-none branch September 8, 2024 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants