-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin mashumaro version >= 3.13.1 for python 3.12.4 compatibility. #121782
Conversation
I noticed there are 3 integrations now using mashumaro directly in home assistant code: |
@allenporter there are more using it, but they use it via |
Ok. I assume our stance is we won't be declaring this directly in integrations anywhere, similar to pydantic, for any of these cases: used directly where symbols are imported, directly in home assistant code using from_json on an object declared in a lib but not directly imported, or indirectly where from_jsom happens only in a library. |
Hmz that seems odd and unneeded. These should indeed either fix their dependencies or adjust otherwise. We should not indirectly assume/depend on those while using it directly in our codebase. ../Frenck |
OK i'll go ahead and add explicit pins for mashumaro and pydantic uses in the code base. |
I honestly think it is better to remove the direct dependency of it in our codebase. |
Makes sense -- would be similar to the approach taken in #103482 which I forgot about. |
…e-assistant#121782) Pin mashumaro version for python 3.12.4 compatibility.
Proposed change
Pin mashumaro>=3.13.1 for python 3.12.4 compatibility. I did not reproduce the original issue, however, tested the version of mashumaro against nest.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: