Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad access to UniFi runtime_data when not assigned #121725

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jul 10, 2024

Breaking change

Proposed change

Previous fix apparently didn't fix all cases where runtime_data could be accessed even when not assigned.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft July 10, 2024 21:42
@frenck
Copy link
Member

frenck commented Jul 10, 2024

Thanks, @Kane610 👍

../Frenck

@Kane610 Kane610 marked this pull request as ready for review July 10, 2024 21:48
@home-assistant home-assistant bot requested a review from frenck July 10, 2024 21:48
@Kane610 Kane610 merged commit 61111f5 into home-assistant:dev Jul 10, 2024
22 checks passed
@Kane610 Kane610 deleted the unifi-improve_handle_runtime_in_config_flow branch July 10, 2024 21:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.