Intent target matching and media player enhancements #115445

synesthesiam · 2024-04-11T21:23:44Z

Breaking changes

The HassLightSet intent no longer checks if the targeted lights support setting brightness before turning them on. This behavior now matches the light.turn_on service.

Proposed change

Extends the target matching capabilities in the intent helper to include:

Requiring specific entity features
Requiring entities to be a specific state
Reporting invalid area/floor names properly
Resolving duplicate entity names with area/floor of satellite device

Media players intents have been updated to take advantage of the extended target matching.
Additionally:

Pause will track the last paused media player(s), and
Unpause will resume the last paused media player(s) if it makes sense

Some missing pieces for later PRs:

Additional intent error messages will be needed for failures due to features and states

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2024-04-11T21:23:51Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of climate can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign climate Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-04-11T21:23:51Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (media_player) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of media_player can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign media_player Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-04-11T21:23:51Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (light) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of light can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign light Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-04-11T21:23:51Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-04-11T21:23:51Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (intent) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of intent can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign intent Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/conversation/default_agent.py

homeassistant/components/intent/__init__.py

balloob · 2024-05-06T17:21:49Z

homeassistant/components/media_player/intent.py

@@ -41,10 +43,88 @@ async def async_setup_intents(hass: HomeAssistant) -> None:
            INTENT_SET_VOLUME,
            DOMAIN,
            SERVICE_VOLUME_SET,
-            extra_slots={
+            required_domains={DOMAIN},
+            required_states={MediaPlayerState.PLAYING},


this is preferred, but is this required?

It's required in the "multiple targets" case (according to the spec, at least). I didn't differentiate between the single and multiple target cases in this PR, and I'm not convinced we should in general. It's now always clear when there will be a single target, so I went with a more conservative approach to start.

homeassistant/helpers/intent.py

balloob

Looking good. Couple of comments.

home-assistant · 2024-05-06T17:31:46Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

synesthesiam added 3 commits April 9, 2024 16:48

Working

7d45a36

Tests are passing

d831076

Fix climate

7459d45

home-assistant bot added cla-signed core has-tests integration: climate integration: conversation integration: intent integration: light integration: media_player new-feature labels Apr 11, 2024

home-assistant bot added Quality Scale: internal by-code-owner labels Apr 11, 2024

synesthesiam marked this pull request as ready for review May 6, 2024 14:21

synesthesiam requested a review from a team as a code owner May 6, 2024 14:21

synesthesiam requested a review from balloob May 6, 2024 16:57