-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename safe mode to recovery mode #102580
Conversation
Hey there @home-assistant/frontend, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/frontend, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a safe_mode
integration, should that be adjusted too?
Proposed change
Rename the core "safe mode" to "recovery mode"
Rationale
We are looking to add a mode that runs Home Assistant without custom integrations and custom frontend resources.
This new mode will help with triaging users that experience issues. Being able to restart Home Assistant in this new mode, will instantly exclude these custom parts as part of the problem when troubleshooting.
After some discussions with several people, "safe mode" felt like the most appropriate term for this, however, we already have a safe mode (which HA will load up when there is a critical issue during startup).
We think it makes sense to rename the latter mode from "safe mode" to "recovery mode"; as it truly is a mode that allows you to fix issues that prevent Home Assistant from starting up.
This frees up "safe mode" for use with a new feature, which is similar to the safe mode we know from Windows back in the day. Regular Home Assistant, without all extras loaded.
This change should be low risk, as these are not features developers built on top of, or are used manually from a user perspective.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: