Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename safe mode to recovery mode #102580

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Rename safe mode to recovery mode #102580

merged 1 commit into from
Oct 23, 2023

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Oct 23, 2023

Proposed change

Rename the core "safe mode" to "recovery mode"

Rationale

We are looking to add a mode that runs Home Assistant without custom integrations and custom frontend resources.

This new mode will help with triaging users that experience issues. Being able to restart Home Assistant in this new mode, will instantly exclude these custom parts as part of the problem when troubleshooting.

After some discussions with several people, "safe mode" felt like the most appropriate term for this, however, we already have a safe mode (which HA will load up when there is a critical issue during startup).

We think it makes sense to rename the latter mode from "safe mode" to "recovery mode"; as it truly is a mode that allows you to fix issues that prevent Home Assistant from starting up.

This frees up "safe mode" for use with a new feature, which is similar to the safe mode we know from Windows back in the day. Regular Home Assistant, without all extras loaded.

This change should be low risk, as these are not features developers built on top of, or are used manually from a user perspective.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/frontend, mind taking a look at this pull request as it has been labeled with an integration (lovelace) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lovelace can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lovelace Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

Hey there @home-assistant/frontend, mind taking a look at this pull request as it has been labeled with an integration (frontend) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of frontend can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign frontend Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (http) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of http can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign http Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a safe_mode integration, should that be adjusted too?

@emontnemery emontnemery merged commit c481fdb into dev Oct 23, 2023
@emontnemery emontnemery deleted the rename_safe_mode branch October 23, 2023 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants