-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rainbird unique to use a more reliable source (mac address) #101603
Merged
MartinHjelmare
merged 14 commits into
home-assistant:dev
from
allenporter:rainbird-mac-address
Nov 12, 2023
Merged
Fix Rainbird unique to use a more reliable source (mac address) #101603
MartinHjelmare
merged 14 commits into
home-assistant:dev
from
allenporter:rainbird-mac-address
Nov 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @konikvranik, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MartinHjelmare
requested changes
Oct 10, 2023
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
20 tasks
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
0105700
to
5132ff7
Compare
MartinHjelmare
requested changes
Nov 8, 2023
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
MartinHjelmare
requested changes
Nov 11, 2023
MartinHjelmare
approved these changes
Nov 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update rainbird unique id selection to use the mac address rather than the serial number, which is sometimes zero. This would have been a better fix for #101168 to handle the zero serial number case in hindsight.
The config flow will now exclusively use the rainbird mac address, which seems to be broadly supported according to testing from the community in allenporter/pyrainbird#270 -- but just incase, we still keep the serial number around in the config entry. We still additionally dedup config entries on unique host/pass given the mix of prior types of unique ids.
Existing config entries that have no unique id (created using the logic in 2023.10.X that skips setting unique id for serial "0") are fixed in the setup to use the mac address. Existing unique ids that use the serial number are left alone.
This is not scheduled for a patch release, since it is a larger change than the previous unique id fixes.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: