-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon file for the Montreal AQI custom integration #6533
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hi there @normcyr 👋
Thanks for opening a pull request. It seem that the provided branding is different from the service provider that this integration integrates with:
Could you take a look?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
You are right! I've added the logo of the city of Montréal to my logo. Great idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a modified version of the upstream branding. We cannot accept those, as these often are violating branding guidelines. Please use the original upstream branding instead.
Thanks! 👍
../Frenck
Alright, I replaced them with the proper branding (I hope!), and added the |
Proposed change
Add an icon to my newly created custom integration, which retrieves the air
quality data for the city of Montréal (Québec, Canada).
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)