Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon file for the Montreal AQI custom integration #6533

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

normcyr
Copy link

@normcyr normcyr commented Feb 9, 2025

Proposed change

Add an icon to my newly created custom integration, which retrieves the air
quality data for the city of Montréal (Québec, Canada).

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @normcyr 👋

Thanks for opening a pull request. It seem that the provided branding is different from the service provider that this integration integrates with:

CleanShot 2025-02-09 at 23 48 23@2x

Could you take a look?

../Frenck

@home-assistant
Copy link

home-assistant bot commented Feb 9, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 9, 2025 22:49
@normcyr
Copy link
Author

normcyr commented Feb 11, 2025

You are right! I've added the logo of the city of Montréal to my logo. Great idea.

@normcyr normcyr marked this pull request as ready for review February 11, 2025 05:07
@home-assistant home-assistant bot requested a review from frenck February 11, 2025 05:07
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a modified version of the upstream branding. We cannot accept those, as these often are violating branding guidelines. Please use the original upstream branding instead.

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 11, 2025 10:47
@normcyr
Copy link
Author

normcyr commented Feb 11, 2025

Alright, I replaced them with the proper branding (I hope!), and added the dark_options. Thank you for your patience as this is my first custom integration 🙂

@normcyr normcyr marked this pull request as ready for review February 11, 2025 15:32
@home-assistant home-assistant bot requested a review from frenck February 11, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants