Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for Computherm B series #6529

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zadoli
Copy link

@zadoli zadoli commented Feb 8, 2025

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@zadoli zadoli changed the title Computherm B series Add icon for Computherm B series Feb 8, 2025
@zadoli zadoli marked this pull request as draft February 10, 2025 09:09
@zadoli zadoli marked this pull request as ready for review February 10, 2025 09:09
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @zadoli 👋

Thanks for the pull request. It seems that the provided branding is modified specifically to target a product? (The b series part).

The branding on their website seems different though:

CleanShot 2025-02-10 at 14 38 46

Could you take a look?

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 10, 2025 13:39
My integration focusing only on B series product of Computherm, so this is why I choed this icon, but now I modified the logo based on the original. Cloud platform for B series: https://computhermbseries.com/
@zadoli zadoli marked this pull request as ready for review February 10, 2025 14:53
@home-assistant home-assistant bot requested a review from frenck February 10, 2025 14:53
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find this icon being used anywhere?

Can you point me to where the manufacturer uses this as their branding for their icons?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 11, 2025 19:54
@zadoli
Copy link
Author

zadoli commented Feb 12, 2025

Hi @frenck!

My integration focusing only on B series product of Computherm, so this is why I choed this icon, but now I modified the logo based on the original, which I got from Wikimedia It is used on the page which you also mentioned before. I changed the color to match the icon for B Series. Is this problem?

Cloud platform for B series: https://computhermbseries.com/

@frenck
Copy link
Member

frenck commented Feb 12, 2025

So, the thing is, we collect manufacturer branding, not product branding. We also cannot accept modified versions of branding assets, as they often violate upstream branding guidelines.

Please use the original manufacturer branding instead.

../Frenck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants