Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (b_route_meter) add new icons and logos for integration #6457

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yufeikang
Copy link

@yufeikang yufeikang commented Jan 29, 2025

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • [ x Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@yufeikang yufeikang marked this pull request as draft January 29, 2025 02:22
@yufeikang yufeikang marked this pull request as ready for review January 29, 2025 05:34
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Feb 6, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @yufeikang 👋

There seems to be an issue with the 2x version of the logo, could you take a look?

CleanShot 2025-02-06 at 08 56 07

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 6, 2025 07:56
@home-assistant
Copy link

home-assistant bot commented Feb 6, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants