-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for micropic_energy_meter #6433
base: master
Are you sure you want to change the base?
Add icons for micropic_energy_meter #6433
Conversation
Hello, this PR is ready for review. Please could you assign a reviewer. Thank you very much. |
Hello, this PR is ready for review. Please could you assign a reviewer. Thank you very much. |
a999e43
to
3c7b2ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hi there @ProyectosMicroPIC 👋
The branding provided in this pull request seems to differ from the branding used on the website:
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi there 👋, ProyectosMicroPIC is my YouTube channel, which is a part of MicroPIC, my blog that has been around for much longer. The branding difference comes from the fact that MicroPIC is the main platform, while ProyectosMicroPIC focuses on video content. You can check out my YouTube channel here: https://www.youtube.com/@proyectosmicropic. Let me know if any adjustments are needed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, we collect manufacturer branding in this repository, which doesn't seem to be the thing that is provided in this pull request.
Looking at the custom integration repo:
And that website shows a different logo.
Can you point me to the location where I can find more information about this product and the manufacturer?
Thanks! 👍
../Frenck
Ah, okay, now I understand what the problem is. |
Well... what we collect here is manufacturer branding, and I'm having issue finding the product and source. If the product isn't available publicly, it means nobody can use this either, than I think there is no reason for us to accept and merge this PR at this moment in time. ../Frenck |
Proposed change
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)