Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for micropic_energy_meter #6433

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

ProyectosMicroPIC
Copy link

@ProyectosMicroPIC ProyectosMicroPIC commented Jan 24, 2025

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@ProyectosMicroPIC
Copy link
Author

Hello, this PR is ready for review. Please could you assign a reviewer. Thank you very much.

@ProyectosMicroPIC ProyectosMicroPIC changed the title Añadidos iconos para micropic_energy_meter Add icons for micropic_energy_meter Feb 3, 2025
@ProyectosMicroPIC
Copy link
Author

Hello, this PR is ready for review. Please could you assign a reviewer. Thank you very much.

@ProyectosMicroPIC ProyectosMicroPIC marked this pull request as draft February 4, 2025 17:09
@ProyectosMicroPIC ProyectosMicroPIC marked this pull request as ready for review February 5, 2025 08:29
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @ProyectosMicroPIC 👋

The branding provided in this pull request seems to differ from the branding used on the website:

CleanShot 2025-02-06 at 18 06 17

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 6, 2025 17:07
@home-assistant
Copy link

home-assistant bot commented Feb 6, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ProyectosMicroPIC
Copy link
Author

Oh hi there @ProyectosMicroPIC 👋

The branding provided in this pull request seems to differ from the branding used on the website:

Hi there 👋,

ProyectosMicroPIC is my YouTube channel, which is a part of MicroPIC, my blog that has been around for much longer. The branding difference comes from the fact that MicroPIC is the main platform, while ProyectosMicroPIC focuses on video content.

You can check out my YouTube channel here: https://www.youtube.com/@proyectosmicropic.

Let me know if any adjustments are needed!

@ProyectosMicroPIC ProyectosMicroPIC marked this pull request as ready for review February 6, 2025 17:59
@home-assistant home-assistant bot requested a review from frenck February 6, 2025 17:59
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, we collect manufacturer branding in this repository, which doesn't seem to be the thing that is provided in this pull request.

Looking at the custom integration repo:

CleanShot 2025-02-06 at 19 01 26

And that website shows a different logo.

Can you point me to the location where I can find more information about this product and the manufacturer?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 6, 2025 18:02
@ProyectosMicroPIC
Copy link
Author

I'm confused, we collect manufacturer branding in this repository, which doesn't seem to be the thing that is provided in this pull request.

Looking at the custom integration repo:

CleanShot 2025-02-06 at 19 01 26

And that website shows a different logo.

Can you point me to the location where I can find more information about this product and the manufacturer?

Thanks! 👍

../Frenck

Ah, okay, now I understand what the problem is.
That page is my blog, and the product Micropic_energy_meter is still in development.
I intend to publish it on the blog once it's finished, but to do so, I first need to publish the add-on in HACS.
That's why you won't find any information yet.
If you need me to modify the URL or add any other information, just let me know.
This is my first experience uploading an add-on to HACS, and I'm not sure if I have completed all the steps correctly.
Thanks

@ProyectosMicroPIC ProyectosMicroPIC marked this pull request as ready for review February 6, 2025 18:22
@home-assistant home-assistant bot requested a review from frenck February 6, 2025 18:22
@frenck
Copy link
Member

frenck commented Feb 6, 2025

Well... what we collect here is manufacturer branding, and I'm having issue finding the product and source.

If the product isn't available publicly, it means nobody can use this either, than I think there is no reason for us to accept and merge this PR at this moment in time.

../Frenck

@frenck frenck marked this pull request as draft February 6, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants