Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add naim media player icons and logos #6429

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jorourke
Copy link

Proposed change

Adding logo and icon for the new custom integration "Naim Media Player", which allows control of Naim Atom audio devices through Home Assistant.

Type of change

  • Add a new logo or icon for a custom integration (custom component)
    • I've added a link to my custom integration repository in the PR description

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@jorourke jorourke force-pushed the naim-home-assistant-2 branch from 715a30f to 65be35d Compare January 24, 2025 11:45
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @jorourke 👋

Thanks for opening a pull request. I took a look and noticed the icons and logos are the same. In those cases, the logo versions can be omitted, as we will automatically fall back to the icon if the logo is missing.

Please remove the logo versions (or, alternatively, add actual logo versions of the branding).

Thanks already! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 6, 2025 07:44
@home-assistant
Copy link

home-assistant bot commented Feb 6, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jorourke jorourke marked this pull request as ready for review February 12, 2025 00:30
@home-assistant home-assistant bot requested a review from frenck February 12, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants