Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo and icons for briiv intergration #6419

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

JWFIVE
Copy link

@JWFIVE JWFIVE commented Jan 23, 2025

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @JWFIVE 👋

I could not find the matching pull request in our core repository that are related to the addition of these core integration branding. Could you please point me to the pull request?

Thanks 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 6, 2025 00:50
@home-assistant
Copy link

home-assistant bot commented Feb 6, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@JWFIVE
Copy link
Author

JWFIVE commented Feb 6, 2025

Hi there @JWFIVE 👋

I could not find the matching pull request in our core repository that are related to the addition of these core integration branding. Could you please point me to the pull request?

Thanks 👍

../Frenck

can you explain this please ?

@frenck
Copy link
Member

frenck commented Feb 6, 2025

Well, this PR adds branding for a core integration, a screenshot from the PR you've made:

CleanShot 2025-02-06 at 18 25 54

So my question is: Where can I find this Home Assistant core integration you are adding here?

../Frenck

@JWFIVE
Copy link
Author

JWFIVE commented Feb 10, 2025

oh I was under the impression that the branding was a prerequisite for the core integration ? I can do a pull for that ?

@frenck
Copy link
Member

frenck commented Feb 11, 2025

oh I was under the impression that the branding was a prerequisite for the core integration ?

It kinda is, but I'm not seeing the core integration. Please link it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants