Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure index redirects are relative #7704

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

philippjfr
Copy link
Member

Fixes #7314

@MarcSkovMadsen
Copy link
Collaborator

That will be such a time saver for people like me on a JupyterHub. Thx.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.60%. Comparing base (50f78eb) to head (18cdbaf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/server.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7704      +/-   ##
==========================================
- Coverage   86.60%   86.60%   -0.01%     
==========================================
  Files         346      346              
  Lines       52494    52530      +36     
==========================================
+ Hits        45465    45494      +29     
- Misses       7029     7036       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit e73f054 into main Feb 12, 2025
16 of 17 checks passed
@philippjfr philippjfr deleted the index_relative_redirect_fix branch February 12, 2025 13:11
@MarcSkovMadsen
Copy link
Collaborator

Just tested the main branch on my JupyterHub. Works for me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirects to /app instead of ./app
2 participants