-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to load inline css #7701
Patch to load inline css #7701
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7701 +/- ##
==========================================
- Coverage 87.07% 86.62% -0.46%
==========================================
Files 346 346
Lines 52671 52698 +27
==========================================
- Hits 45863 45649 -214
- Misses 6808 7049 +241 ☔ View full report in Codecov by Sentry. |
Grearly appreciate you reviving this, and I promise to take a more detailed look at this very soon. At a high level I have some concerns with the PR.
|
Thanks a lot @fabiovincenzi and @philippjfr for getting this to completion and merging it when I wasn't able to spend much time on it. |
This PR is based on the work done in #6607 by @pankajp, which aimed to make Tabulator work offline in Jupyter Notebook when pn.config.inline=True. Since that PR currently has merge conflicts and hasn’t been updated recently, I’ve resolved the conflicts and made the necessary adjustments to ensure smooth integration.
Fixes #5167, #3959