Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to load inline css #7701

Merged
merged 13 commits into from
Feb 13, 2025
Merged

Patch to load inline css #7701

merged 13 commits into from
Feb 13, 2025

Conversation

fabiovincenzi
Copy link
Contributor

@fabiovincenzi fabiovincenzi commented Feb 11, 2025

This PR is based on the work done in #6607 by @pankajp, which aimed to make Tabulator work offline in Jupyter Notebook when pn.config.inline=True. Since that PR currently has merge conflicts and hasn’t been updated recently, I’ve resolved the conflicts and made the necessary adjustments to ensure smooth integration.

Fixes #5167, #3959

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.62%. Comparing base (b17ddfd) to head (9ff1cf2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
panel/viewable.py 53.84% 6 Missing ⚠️
panel/io/notebook.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7701      +/-   ##
==========================================
- Coverage   87.07%   86.62%   -0.46%     
==========================================
  Files         346      346              
  Lines       52671    52698      +27     
==========================================
- Hits        45863    45649     -214     
- Misses       6808     7049     +241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Grearly appreciate you reviving this, and I promise to take a more detailed look at this very soon. At a high level I have some concerns with the PR.

  1. This only patches the stylesheets when the table is rendered initially. If the table is added dynamically at some later point it won't catch that.
  2. I'm not convinced that adding the inline resource handling in render_mimebundle does anything.

@philippjfr philippjfr merged commit 1a3bed4 into holoviz:main Feb 13, 2025
17 of 18 checks passed
@pankajp
Copy link

pankajp commented Feb 14, 2025

Thanks a lot @fabiovincenzi and @philippjfr for getting this to completion and merging it when I wasn't able to spend much time on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS is missing when inlining static resources.
3 participants