-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify Player/DiscretePlayer with scale_buttons/visible_buttons/visible_loop_options #7065
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7065 +/- ##
==========================================
- Coverage 82.22% 82.20% -0.03%
==========================================
Files 327 327
Lines 48923 48970 +47
==========================================
+ Hits 40229 40256 +27
- Misses 8694 8714 +20 ☔ View full report in Codecov by Sentry. |
Needs a merge/rebase it looks like. |
1c95769
to
dbce9db
Compare
Ok rebased it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments on the tests, otherwise looks good!
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
327e235
to
feb2e14
Compare
Make it a little less bulky
button_scale=1
