Avoid overeager garbage collection #6518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #6502 I discovered that we still run garbage collection whenever a session is destroyed. Previously we had set up scheduled tasks to run garbage collection AFTER a session is destroyed ensuring that if multiple sessions are closed in succession we only run the task once. In this PR we do two things:
_on_session_destroyed
handler onDocumentLifecycleHandler
overriding the default handler which runs garbage collectionDocument.destroy
garbage collection task so it runs 5 seconds after the last session was destroyed, i.e. if multiple sessions are destroyed in quick succession we only run the garbage collection cycle 5 seconds after the last session is destroyed.