Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary cleanup of the TS codebase #6406

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Conversation

mattpap
Copy link
Collaborator

@mattpap mattpap commented Feb 28, 2024

This PR:

  • updates eslint.js to match bokehjs'
  • updates tsconfig.json to match bokehjs (as much as possible)
  • fixes all trivial lint errors (styling related, type imports, etc.)
  • fixes all errors resulting from tsconfig.json changes
    • adds missing or fixes misused override and declare modifiers
    • fixes a few stray type errors

@mattpap mattpap added this to the v1.4.0 milestone Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.64%. Comparing base (d35e55b) to head (01ebaf0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6406      +/-   ##
==========================================
- Coverage   71.65%   71.64%   -0.01%     
==========================================
  Files         305      305              
  Lines       45730    45730              
==========================================
- Hits        32766    32765       -1     
- Misses      12964    12965       +1     
Flag Coverage Δ
unitexamples-tests 71.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11
Copy link
Contributor

ahuang11 commented Feb 28, 2024

@mattpap
Copy link
Collaborator Author

mattpap commented Feb 28, 2024

Any ideas if anything in this needs changing?

Yes, quite a few things, but we will resolve this depending on the PR merge order, because some of the required changes may not be applicable until tsconfig.json is updated.

@mattpap
Copy link
Collaborator Author

mattpap commented Mar 1, 2024

@philippjfr, maybe we could get this merged unless there are any concerns? I have some more gradual follow up work I would like to submit.

@philippjfr philippjfr merged commit 75405ae into main Mar 1, 2024
9 of 15 checks passed
@philippjfr philippjfr deleted the mattpap/ts_codebase branch March 1, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants