-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary cleanup of the TS codebase #6406
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6406 +/- ##
==========================================
- Coverage 71.65% 71.64% -0.01%
==========================================
Files 305 305
Lines 45730 45730
==========================================
- Hits 32766 32765 -1
- Misses 12964 12965 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Any ideas if anything in this needs changing? |
Yes, quite a few things, but we will resolve this depending on the PR merge order, because some of the required changes may not be applicable until |
825ac0c
to
01ebaf0
Compare
@philippjfr, maybe we could get this merged unless there are any concerns? I have some more gradual follow up work I would like to submit. |
This PR:
eslint.js
to match bokehjs'tsconfig.json
to match bokehjs (as much as possible)tsconfig.json
changesoverride
anddeclare
modifiers