More complete patch for the TextEditor to support being rendered in the Shadow DOM #6222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6222 +/- ##
===========================================
+ Coverage 22.35% 84.18% +61.83%
===========================================
Files 299 301 +2
Lines 44647 45099 +452
===========================================
+ Hits 9980 37967 +27987
+ Misses 34667 7132 -27535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
philippjfr
requested changes
Jan 17, 2024
Done in cb89e1a using the built-in formatter in VSCode. |
philippjfr
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a complex application using the TextEditor widget it becomes unusable after certain operations. I couldn't reproduce the bug with a simple example. I found a Shadow DOM patch (slab/quill#2961 (comment)) that looked more complete and that made other Quill users happy, so I decided to try it out. It seems like it fixed my issue! I've updated a test as it fixes another issue (see the last paragraph of this comment #5511 (comment)).