Improve HoloViews reference guide #6065
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6065 +/- ##
==========================================
- Coverage 71.52% 71.48% -0.04%
==========================================
Files 310 312 +2
Lines 45996 46050 +54
==========================================
+ Hits 32898 32921 +23
- Misses 13098 13129 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| "hvplot.extension(\"plotly\")\n", | ||
| "\n", | ||
| "plot = df.hvplot.scatter(x=\"group\", y=\"value\", height=300, responsive=True)\n", | ||
| "pn.pane.HoloViews(plot, backend='plotly', height=300)" |
There was a problem hiding this comment.
There is a bug here. The resulting plot is higher than the 300px specified both with hvPlot and HoloViews.
| "\n", | ||
| "pn.Column(\n", | ||
| " pn.Row(*widgets),\n", | ||
| " hv_panel[0])" | ||
| " \"## Not Centered: `center=False`\",\n", |
There was a problem hiding this comment.
Does center work as expected when combined with sizing_mode?
- I dont understand why the first example is not left aligned. I would expect the layout to have a fixed width.
- I don't understand why the plot in the first and second examples have different widths.
But I can find a way to achieve what I need.
|
There are so many issues here. I need an expert on HoloViews (the framework) and HoloViews (the pane) to go through my comments and give me some feedback on who should do what. I don't plan to do more before I get that feedback. |
|
Maybe I forgot to "release this". I've done that now. It is ready for review. |
|
I'll retarget for 1.4.0 because I don't want to hold up the release much more, but if I do get a chance before tomorrow I will backport it. |
fa5abc9 to
74ee0b6
Compare
Via #5628 its clear that the
HoloViewsreference notebook does not clearly explain how things are expected to work. After working with it I can also see that its not updated to reflect how theHoloViewspane works today. I also believe some of the things that are explained does not work due to bugs.