Add Support for webp format

[vaniisgh]

Adding support to add webp files.
#5612

[codecov]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (f9d9a58) 83.65% compared to head (8931f9a) 39.11%.

❗ Current head 8931f9a differs from pull request most recent head f8e17bb. Consider uploading reports for the commit f8e17bb to get more accurate results

Files	Patch %	Lines
panel/pane/image.py	35.71%	9 Missing ⚠️
panel/tests/pane/test_image.py	50.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #6035       +/-   ##
===========================================
- Coverage   83.65%   39.11%   -44.55%     
===========================================
  Files         305      305               
  Lines       45518    45519        +1     
===========================================
- Hits        38079    17805    -20274     
- Misses       7439    27714    +20275     

Flag	Coverage Δ
ui-tests	39.11% <40.00%> (-0.54%)	⬇️
unitexamples-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hoxbro]

I have uploaded the tree here: https://assets.holoviz.org/panel/samples/webp_sample.webp

[ahuang11]

Thanks for adding support for webp! Looks good to me! Just some minor suggestions and if you can add a test similar to the other image tests!

[vaniisgh]

Thanks for your comments I will just get to it 😄

[vaniisgh]

hey, im struggling a bit to get the width and height to be set correctly in imgshp does anyone have any suggestions ?
from what I read I seem to be unpacking it correctly. and the base64 image also has the correct header... not sure what im doing wrong ...

[ahuang11]

Hey @vaniisgh sorry for the late reply!

My naive testing suggest it seems to be working. Can you elaborate on what the remaining issue is?

[ahuang11]

Maybe we can use a context manager here:

with BytesIO(data) as b:
    ...

[ahuang11]

This seems to work for the sample image:

import requests

response = requests.get("https://assets.holoviz.org/panel/samples/webp_sample.webp")
data = response.content

with open("webp_sample.webp", "wb") as f:
    f.write(data)

def get_webp_dimensions(file_path):
    with open(file_path, 'rb') as f:
        header = f.read(30) 
        width = int.from_bytes(header[26:28], byteorder='little')
        height = int.from_bytes(header[28:30], byteorder='little')

    return width, height

get_webp_dimensions("webp_sample.webp")

Returns:
(320, 241)

Which agrees with Mac's preview

[vaniisgh]

I think the issue only occurs in the test case ? Maybe the image I have created is incorrect... from base64 to webP. maybe I am not reading the header correctly, you seem to have done it a little different. let me just try it like your demonstration.

while asserting the w,h. though I used the same image as the ones used in png, jpeg etc so I think that can't be the problem.

[ahuang11]

Yes maybe the image might be incorrectly created; perhaps you can use another image if that's the case.

[philippjfr]

Many thanks for your work on this @vaniisgh, really appreciated!

[vaniisgh]

Thanks, sorry for the long period of inactivity

[philippjfr]

Think that was mostly on us tbh.