-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle icon #6034
Add toggle icon #6034
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6034 +/- ##
==========================================
+ Coverage 84.67% 84.70% +0.03%
==========================================
Files 291 295 +4
Lines 43816 43885 +69
==========================================
+ Hits 37101 37173 +72
+ Misses 6715 6712 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Good start! Next we probably have to create and sync a bunch properties between this wrapper and the underlying icon model. |
Okay this is ready for the next release I think! Feel free to make changes directly as needed. A couple notes for future enhancements: #6037
ToggleIcon Screen.Recording.2023-12-13.at.7.52.38.PM.movChatMessage (made it more efficient!) Screen.Recording.2023-12-13.at.7.54.56.PM.mov |
Closes #6022
To be used for ChatReactionIcons