-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve fast templates #6023
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6023 +/- ##
==========================================
+ Coverage 84.65% 84.67% +0.01%
==========================================
Files 291 291
Lines 43458 43586 +128
==========================================
+ Hits 36788 36905 +117
- Misses 6670 6681 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -214,6 +214,10 @@ img.app-logo { | |||
margin-block-end: 0; | |||
} | |||
|
|||
div.pn-wrapper { | |||
height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about this one?
{% if not main_layout %} | ||
background-color: var(--panel-surface-color); | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% if not main_layout %} | |
background-color: var(--panel-surface-color); | |
{% endif %} | |
{% if not main_layout %} | |
background-color: var(--panel-surface-color); | |
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just want to be sure that the 100% height on pn-wrapper works well in all cases.
Its a good question. I can see that the fast-card has this by it self. Isabella tested in an app with two elements in main area. And it was fine. |
I'll merge and will make sure to do some testing over the next few days. |
This PR fixes various fast styling issues introduced by Panel 1.0.
Select
widget visible - also in dark mode.It also improves the template styling when
main_layout=None
giving it the familiar Streamlit Gray Sidebar look. I think I will be using this version and more and more because I think it looks the best.main_layout
toNone
in Panel 1.6 or similar?I also add a tiny bid of left padding to the sidebar too make it look more symmetric and less cramped.
I also fix #6024.
Test Script
I've been using the below test script
After
This is how things will be looking when applying this PR.
main_layout=None