Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate property VizzuChart.config #5947

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

cdeil
Copy link
Contributor

@cdeil cdeil commented Nov 29, 2023

This looks like a duplicate property? It's already defined on line 44.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7957f6) 82.68% compared to head (0a4c9bb) 82.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5947      +/-   ##
==========================================
- Coverage   82.68%   82.67%   -0.01%     
==========================================
  Files         291      291              
  Lines       43076    43075       -1     
==========================================
- Hits        35616    35611       -5     
- Misses       7460     7464       +4     
Flag Coverage Δ
ui-tests 38.61% <ø> (+<0.01%) ⬆️
unitexamples-tests 72.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @cdeil!

@philippjfr
Copy link
Member

I'll have to find a way to skip those OAuth tests for external contributors since the secrets aren't defined in that case.

@philippjfr philippjfr merged commit fcd3d23 into holoviz:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants