Enable selection across different pages with pagination="remote" and selectable="checkbox"

[hoxbro]

Fixes #4367

import numpy as np
import pandas as pd
import panel as pn

pn.extension("tabulator")

data = np.arange(20) + 100
df = pd.DataFrame(data)
tab = pn.widgets.Tabulator(
    value=df,
    disabled=True,
    pagination="remote",
    page_size=10,
    selectable="checkbox",
    header_filters=True,
)
tab.servable()

screenrecord-2023-11-17_17.17.53.mp4

[codecov]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (f0b1832) 84.41% compared to head (ab16e1c) 84.15%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
panel/widgets/tables.py	72.00%	7 Missing ⚠️
panel/models/tabulator.py	50.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5889      +/-   ##
==========================================
- Coverage   84.41%   84.15%   -0.26%     
==========================================
  Files         291      291              
  Lines       42655    42764     +109     
==========================================
- Hits        36007    35988      -19     
- Misses       6648     6776     +128     

Flag	Coverage Δ
ui-tests	40.95% <85.24%> (+0.12%)	⬆️
unitexamples-tests	72.41% <17.21%> (-0.44%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maximlt]

I've left some comments. I have noticed that when selecting all the rows with the tickbox that is in the header, it selects the rows of the displayed page only. The behavior with local pagination is to select all the rows. Is that on purpose?

Very happy to see these many UI tests! 👍

[maximlt]

Instead of indices, selected, how about having selected, deselected, each one of the latter being a list (empty or not) of indices? Asking since it wasn't first obvious to me what selected would hold.

[hoxbro]

I am not the biggest fan of the names I have chosen.

Your suggestion could also be confusing since the indices are only updated ones and not a full list of selected/deselected indices.

@philippjfr, any preferences?

[philippjfr]

No real preference, a comment to clarify is probably more important than the naming here since these events won't be user facing.

[philippjfr]

@hoxbro My main question is whether the title is still accurate? The idea was to support cross-page selection for all selection modes, not just the "checkbox" mode, but I'd be happy if your answer was that you will follow up in another PR.

[hoxbro]

I have noticed that when selecting all the rows with the tickbox that is in the header, it selects the rows of the displayed page only. The behavior with local pagination is to select all the rows. Is that on purpose?

Not more than that was how it manifested itself when clicking on the top tickbar. It made sense to me that it would only select the current page, as this is how it works in apps like Gmail.

My main question is whether the title is still accurate? The idea was to support cross-page selection for all selection modes, not just the "checkbox" mode, but I'd be happy if your answer was that you will follow up in another PR.

The title should still be accurate as selectable=True goes down a different function in TypeScript this.rowClicked, where change here is done in this.rowSelectionChanged.

Don't worry; I will add this in another PR 🙂

https://github.com/holoviz/panel/pull/5889/files#diff-62ea1172d9fa28fbf400f9dae9e61bf030147840e9c9efe43d95287c653a4b63L479