Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text_align to existing formatter #5866

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Add text_align to existing formatter #5866

merged 6 commits into from
Nov 15, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 13, 2023

Fixes #5807 and fixes #5876

@hoxbro hoxbro marked this pull request as draft November 13, 2023 17:08
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7eb9c71) 84.00% compared to head (d8eb9d0) 84.00%.
Report is 3 commits behind head on main.

Files Patch % Lines
panel/widgets/tables.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5866   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files         290      290           
  Lines       42391    42425   +34     
=======================================
+ Hits        35609    35639   +30     
- Misses       6782     6786    +4     
Flag Coverage Δ
ui-tests 40.90% <44.00%> (+<0.01%) ⬆️
unitexamples-tests 72.36% <98.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro marked this pull request as ready for review November 15, 2023 10:52
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hoxbro
Copy link
Member Author

hoxbro commented Nov 15, 2023

Need to update warn message one more place

@philippjfr
Copy link
Member

Failures seem unrelated, but I have to say I'm quite perplexed by FAILED panel/tests/io/test_cache.py::test_per_session_cache - ValueError: Callback functions must have signature func(session_context), got func(session_context=None). How can this happen transiently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to Bokeh formatters give 404 not found Tabulator text_align is not working with Bokeh NumberFormatter
2 participants