Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not freeze document models unless needed #5864

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Do not freeze document models unless needed #5864

merged 4 commits into from
Nov 13, 2023

Conversation

philippjfr
Copy link
Member

Currently we freeze the Document model references every time a property is changed, triggering reference invalidation which is expensive. Instead we should check if we are adding/removing a model and only freeze the model references if that's the case.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #5864 (8036929) into main (ba97f63) will increase coverage by 1.59%.
The diff coverage is 80.76%.

@@            Coverage Diff             @@
##             main    #5864      +/-   ##
==========================================
+ Coverage   82.37%   83.96%   +1.59%     
==========================================
  Files         290      290              
  Lines       42296    42318      +22     
==========================================
+ Hits        34842    35533     +691     
+ Misses       7454     6785     -669     
Flag Coverage Δ
ui-tests 40.89% <23.07%> (+2.49%) ⬆️
unitexamples-tests 72.34% <80.76%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/layout/base.py 90.66% <100.00%> (+0.03%) ⬆️
panel/io/document.py 71.68% <88.88%> (+25.42%) ⬆️
panel/layout/grid.py 74.40% <25.00%> (-0.13%) ⬇️

... and 16 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@philippjfr philippjfr merged commit 8128ca2 into main Nov 13, 2023
@philippjfr philippjfr deleted the freeze_models branch November 13, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant