AutocompleteInput: expose and document search_strategy
#5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5832 +/- ##
===========================================
+ Coverage 72.37% 83.93% +11.55%
===========================================
Files 290 290
Lines 42235 42236 +1
===========================================
+ Hits 30566 35449 +4883
+ Misses 11669 6787 -4882
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 78 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Test failures look unrelated. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3117
Very very happy to find out that Bokeh added in bokeh/bokeh#13032 a
search_strategyproperty toAutocompleteInputthat when set to'includes'allows to to search through the whole string and not just the start.In #3117 I was asking specifically for a Search widget but I think I had a too narrow vision of what autocomplete means, I think it can closed as bokeh/bokeh#13032 implemented the feature I was after.