Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure invalid query parameters warn instead of erroring #5781

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

philippjfr
Copy link
Member

An invalid query parameter should not be able to break an app.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #5781 (0f380ee) into main (f8a8b08) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #5781      +/-   ##
==========================================
- Coverage   73.61%   73.61%   -0.01%     
==========================================
  Files         290      290              
  Lines       42224    42231       +7     
==========================================
+ Hits        31085    31087       +2     
- Misses      11139    11144       +5     
Flag Coverage Δ
unitexamples-tests 73.61% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/util/__init__.py 83.27% <66.66%> (-0.39%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit a233456 into main Oct 31, 2023
@philippjfr philippjfr deleted the url_parse_warning branch October 31, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants