Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iframe srcdoc to Location #5774

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

MarcSkovMadsen
Copy link
Collaborator

Closes #5506

@MarcSkovMadsen MarcSkovMadsen added this to the v1.3.1 milestone Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #5774 (64599fd) into main (c03d782) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5774      +/-   ##
==========================================
- Coverage   73.69%   73.62%   -0.07%     
==========================================
  Files         289      289              
  Lines       42116    42118       +2     
==========================================
- Hits        31036    31010      -26     
- Misses      11080    11108      +28     
Flag Coverage Δ
unitexamples-tests 73.62% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/io/location.py 80.42% <100.00%> (ø)
panel/tests/io/test_location.py 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit f645147 into main Oct 30, 2023
@philippjfr philippjfr deleted the fix/iframe-srcdoc branch October 30, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError when embedding Panel Server App in Iframe
2 participants