Small tweaks for Material template and theme #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5676 +/- ##
===========================================
+ Coverage 73.74% 84.06% +10.32%
===========================================
Files 288 288
Lines 41967 41990 +23
===========================================
+ Hits 30947 35299 +4352
+ Misses 11020 6691 -4329
Flags with carried forward coverage won't be shown. Click here to find out more. see 81 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahuang11
reviewed
Oct 18, 2023
panel/theme/css/material.css
Outdated
| @@ -228,6 +228,10 @@ button.mdc-button.mdc-card-button { | |||
| margin-top: 0.5rem; | |||
There was a problem hiding this comment.
Wondering if this is necessary? I also noticed it making the text input + buttons not aligned.
There was a problem hiding this comment.
If I remove the margin-top, it's aligned
|
Awesome thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5672