TextEditor: hacks to re-enable rendering on Firefox and copy/paste #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5609 +/- ##
==========================================
- Coverage 83.50% 82.57% -0.93%
==========================================
Files 275 276 +1
Lines 39549 39631 +82
==========================================
- Hits 33024 32727 -297
- Misses 6525 6904 +379
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hoxbro
reviewed
Oct 10, 2023
philippjfr
approved these changes
Oct 10, 2023
ahuang11
pushed a commit
that referenced
this pull request
Oct 10, 2023
…5609) * hacks to fix copy/paste and rendering on Firefox * Fix copy-paste test on non-OSX platforms --------- Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
ahuang11
pushed a commit
that referenced
this pull request
Oct 10, 2023
…5609) * hacks to fix copy/paste and rendering on Firefox * Fix copy-paste test on non-OSX platforms --------- Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5545
Fixes #5600
"Fixes" is a bit exaggerated!
Basically I've noticed that the selection parsed by
normalizeNativecontained a node the code didn't expect so I tried to returnnullin that case and it worked (even if there's still an error in the console...).On rendering in Firefox, browsers have different level of support for the Selection API and patching it for Firefox made things worse obviously, so I've disabled that and the widget can be rendered again and interacted with (there are still some weird behaviors).
Until Quill supports being rendered in the Shadow DOM, or we find a proper way to patch it, the TextEditor widget is going to behave strangely in some cases.