Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown rendering with the MyST parser (#5494) #5497

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fix markdown rendering with the MyST parser (#5494) #5497

merged 1 commit into from
Sep 11, 2023

Conversation

monodera
Copy link
Contributor

@monodera monodera commented Sep 9, 2023

MyST parser does not work with Panel 1.2.2 (#5494) and the commit fixes it.

- MyST parser does not work with Panel 1.2.2 (#5494) and the commit fixes it.
@monodera
Copy link
Contributor Author

monodera commented Sep 9, 2023

BTW, the fix was suggested by @ahuang11 and I just followed it.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #5497 (54e0bc4) into main (36a1d92) will decrease coverage by 10.71%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5497       +/-   ##
===========================================
- Coverage   83.28%   72.58%   -10.71%     
===========================================
  Files         275      275               
  Lines       40124    40124               
===========================================
- Hits        33419    29122     -4297     
- Misses       6705    11002     +4297     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 72.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/pane/markup.py 89.78% <100.00%> (ø)

... and 68 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Thanks @monodera, appreciate the contribution!

@philippjfr philippjfr merged commit b1d1f9d into holoviz:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants