Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of string dtypes for Perspective #5467

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

philippjfr
Copy link
Member

Partial fix for #5081

@philippjfr philippjfr marked this pull request as ready for review September 1, 2023 12:06
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #5467 (86dd134) into main (92e3982) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main    #5467   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         274      275    +1     
  Lines       40111    40124   +13     
=======================================
+ Hits        29109    29121   +12     
- Misses      11002    11003    +1     
Flag Coverage Δ
unitexamples-tests 72.57% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/pane/perspective.py 58.86% <80.00%> (+1.50%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 6bc3a07 into main Sep 1, 2023
@philippjfr philippjfr deleted the perspective_dtypes branch September 1, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant