Do no reset Tabulator if DataFrame indexes are unchanged #5436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5436 +/- ##
===========================================
- Coverage 83.29% 72.61% -10.68%
===========================================
Files 274 274
Lines 40010 40016 +6
===========================================
- Hits 33326 29059 -4267
- Misses 6684 10957 +4273
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 64 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when a user updates the
valueof a table we reset a bunch of settings because effectively anything about the data might have changed. However a) a user can reset these themselves and b) as long as the settings are valid then not resetting shouldn't cause any issues. Here we make an initial conservative change in this direction and avoid resetting theexpandedproperty as long as the indexes of the DataFrame being displayed are unchanged.