-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5424 : update echarts when removing series #5435
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5435 +/- ##
==========================================
+ Coverage 72.59% 72.61% +0.01%
==========================================
Files 274 274
Lines 39964 40005 +41
==========================================
+ Hits 29013 29048 +35
- Misses 10951 10957 +6
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for the contribution @pierrotsmnrd .I don't have more to add. (I've been reading the PR. Not testing it out). |
Great work and congrats on your first PR @pierrotsmnrd! |
This PR fixes issue #5424.
The fix is very simple and is based on a workaround described in the original issue on Apache Echarts (thanks @MarcSkovMadsen for pointing it out)