Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5424 : update echarts when removing series #5435

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

pierrotsmnrd
Copy link
Collaborator

This PR fixes issue #5424.

The fix is very simple and is based on a workaround described in the original issue on Apache Echarts (thanks @MarcSkovMadsen for pointing it out)

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #5435 (49be3ec) into main (78abc39) will increase coverage by 0.01%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

❗ Current head 49be3ec differs from pull request most recent head 37f11db. Consider uploading reports for the commit 37f11db to get more accurate results

@@            Coverage Diff             @@
##             main    #5435      +/-   ##
==========================================
+ Coverage   72.59%   72.61%   +0.01%     
==========================================
  Files         274      274              
  Lines       39964    40005      +41     
==========================================
+ Hits        29013    29048      +35     
- Misses      10951    10957       +6     
Flag Coverage Δ
unitexamples-tests 72.61% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MarcSkovMadsen
Copy link
Collaborator

Thanks for the contribution @pierrotsmnrd .I don't have more to add.

(I've been reading the PR. Not testing it out).

@philippjfr
Copy link
Member

Great work and congrats on your first PR @pierrotsmnrd!

@philippjfr philippjfr merged commit aba1b1a into holoviz:main Aug 30, 2023
@philippjfr philippjfr modified the milestones: next, v1.2.2 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants