Add Perspective click events #5430
Conversation
Only tested on data grid
Codecov Report
@@ Coverage Diff @@
## main #5430 +/- ##
===========================================
- Coverage 83.11% 72.59% -10.52%
===========================================
Files 274 274
Lines 39601 40046 +445
===========================================
- Hits 32913 29071 -3842
- Misses 6688 10975 +4287
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 98 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -44,6 +44,10 @@ | |||
| "* **``theme``** (str): The theme of the viewer, available options include `'material'`, `'material-dark'`, `'monokai'`, `'solarized'`, `'solarized-dark'` and `'vaporwave'`\n", | |||
| "* **``toggle_config``** (bool): Whether to show the config menu. Default is True.\n", | |||
| "\n", | |||
| "##### Callbacks\n", | |||
There was a problem hiding this comment.
What is really the strategy for events?
- Should we always implement it in a way such that we can
pn.bindto events? - Do we at all want to expose call back method?
Are there other events we could/ should add. I believe the Perspective Viewer can be editable. Are there any events signaling a cell update? What I've been able to find is
There was a problem hiding this comment.
Should we always implement it in a way such that we can pn.bind to events?
Yes, I've got a half-finished implementation of an EventBus object which can be added to an object, which exposes events as parameters. I'll target this for the 1.3 release.
Are there other events we could/ should add. I believe the Perspective Viewer can be editable. Are there any events signaling a cell update? What I've been able to find is
I also looked at this but haven't really worked out which event would signal an edit.
|
Will merge this as is and then improve event handling across the board in 1.3. |
Supersedes #5416