Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication handling when prefix is set #5422

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

philippjfr
Copy link
Member

Fixes #5398

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #5422 (a5d2370) into main (2f1e42a) will decrease coverage by 12.55%.
Report is 2 commits behind head on main.
The diff coverage is 30.00%.

@@             Coverage Diff             @@
##             main    #5422       +/-   ##
===========================================
- Coverage   82.75%   70.20%   -12.55%     
===========================================
  Files         274      274               
  Lines       39897    39919       +22     
===========================================
- Hits        33015    28025     -4990     
- Misses       6882    11894     +5012     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 70.20% <30.00%> (-2.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/auth.py 36.38% <0.00%> (ø)
panel/tests/ui/test_auth.py 38.46% <25.00%> (-11.54%) ⬇️
panel/io/server.py 67.45% <44.44%> (-5.55%) ⬇️

... and 77 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 68f0d93 into main Aug 21, 2023
@philippjfr philippjfr deleted the auth_prefix_handling branch August 21, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Authentication does not work when launched with prefix
1 participant