Inherit new scroll functionalities from Column in ChatBox log #5310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
73f3e45 to
23e3d4e
Compare
8 tasks
|
Closing in favor of #5333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 73f3e45 for changes.
Builds upon #5245 and works very well; I think I need to
raise NotImplementedErrorforascending=Falseandauto_scroll=Trueorscroll_button_thresholdWhile testing, I realized auto_scroll should also include a threshold
auto_scroll_thresholdfor cases where the logs/messages are streaming, but the user just wants to see the old messages.Closes #5236 and partially addresses #5135