Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyodide and pyscript and switch to pyc build #5309

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

philippjfr
Copy link
Member

Implements #5303

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #5309 (5c5bf1a) into main (9c0d993) will decrease coverage by 0.11%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #5309      +/-   ##
==========================================
- Coverage   82.84%   82.73%   -0.11%     
==========================================
  Files         274      274              
  Lines       39701    39708       +7     
==========================================
- Hits        32890    32854      -36     
- Misses       6811     6854      +43     
Flag Coverage Δ
ui-tests 39.50% <57.14%> (-0.02%) ⬇️
unitexamples-tests 72.76% <50.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/pyodide.py 0.00% <0.00%> (ø)
panel/io/convert.py 72.59% <100.00%> (+0.41%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MarcSkovMadsen
Copy link
Collaborator

Have you tried the latest PyScript with Panel, for me it raised an exception on a simple example that worked with previous version

@philippjfr
Copy link
Member Author

We have multiple UI tests that seem to be passing.

@philippjfr philippjfr merged commit e8230a3 into main Jul 24, 2023
@philippjfr philippjfr deleted the pyodide_compiled branch July 24, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants