Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize rendering of HTML based component #5275

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Optimize rendering of HTML based component #5275

merged 2 commits into from
Jul 18, 2023

Conversation

philippjfr
Copy link
Member

Avoids full re-render when it is not needed on Bokeh models that implement a View that is a subclass of PanelMarkupView.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #5275 (91517c6) into main (8fd765b) will increase coverage by 11.18%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5275       +/-   ##
===========================================
+ Coverage   72.59%   83.78%   +11.18%     
===========================================
  Files         274      274               
  Lines       39649    39655        +6     
===========================================
+ Hits        28783    33223     +4440     
+ Misses      10866     6432     -4434     
Flag Coverage Δ
ui-tests 40.37% <0.00%> (?)
unitexamples-tests 73.73% <100.00%> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/widgets/indicators.py 73.77% <100.00%> (+0.15%) ⬆️

... and 74 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit d653fbf into main Jul 18, 2023
@philippjfr philippjfr deleted the optimize_render branch July 18, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant