-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binder #5257
Fix binder #5257
Conversation
@@ -139,3 +139,13 @@ doc/reference/* | |||
!/panel/dist/css | |||
!/panel/dist/css/*.css | |||
.venv2/ | |||
.npm/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files below are added to the root of the Panel project on binder. So to not show them in VS code git changes I remove them.
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@maximlt How much of a pain would this rebase be for you if I merged it right now? |
No problem go for it. |
Thanks guys. I'm just checking once more on Binder to be 100% certain this works. |
Codecov Report
@@ Coverage Diff @@
## main #5257 +/- ##
==========================================
- Coverage 83.83% 83.60% -0.23%
==========================================
Files 274 274
Lines 39606 39649 +43
==========================================
- Hits 33203 33149 -54
- Misses 6403 6500 +97
Flags with carried forward coverage won't be shown. Click here to find out more. see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
With the Fix Binder PR at least I have one place to point users to a working environment. It might not be optimal and well performing. But its there. At work we can have a new employee up and running on our Jupyter hub with tools, repositories, python environments, data etc. in 15 minutes. When we install repositories for development we can always just do pip install -e .[dev]. When we want to build the docs we can just do mt build.docs etc. So its very, very easy for people not familiar with coding, git etc. to get started. I would really, really love to get closer to a situation like that for this project too. |
Indeed, that's the goal of the |
We also have lots of non-python dependencies. But they are pre-installed on the docker notebook/ vs code images we provide to developers. That is why I wanted to try getting it working for codespaces in #5250 |
Oh I'm sure you're not comparing the capabilities of a large energy company with those of an OSS project! Good job anyway, of course not all large companies have such a good set up process, it must be great to work at your place.
I have never had to use a docker image to contribute to a Python project. I can easily imagine that would be a barrier to contribution. Overall what we have is:
There's no magic trick to improve all of that, you just have to put in a lot of hard work. What would help a lot would be dedicated funding, maybe there are special funding for helping OSS projects with managing their infrastructure and improving their contributor's experience. I doubt any company would fund that work, but who knows! |
Just to be sure. Users dont care about or use Docker. They just log into jupyter or vs code on the web. Its the same that binder and codespaces provides. Ours is just more powerful and with resources and data integrated. What I wanted to try out for Panel was codespaces to see if the free tier is powerful enough to provide the same experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Makes binder work again
Try it out https://mybinder.org/v2/gh/holoviz/panel/fix/binder?urlpath=lab/tree/examples.
Closes