-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scroll log with ReactiveHTML #5212
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5212 +/- ##
=======================================
Coverage 83.82% 83.83%
=======================================
Files 274 275 +1
Lines 39594 39610 +16
=======================================
+ Hits 33189 33206 +17
+ Misses 6405 6404 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Awesome Somehow we are missing a Concept for adding "actions" like AutoScroll, FullScreen, Sort, etc. to a Column without having to implement a new container component each time @philippjfr |
While this functionality is great, I too do not think we should implement a new container component every time we want to add some functionality like this. |
Sure. So as a way forward, should |
I think a component as fundamental as Row and Column should still be implemented as a Bokeh model, so we'd have to subclass |
Suggestions on what it would be called? |
Sorry, if I wasn't clear, |
Any docs/resources/steps to take/existing examples in the repo on how create a typescript file that subscripts Bokeh Column? |
Okay, I attempted to convert to Typescript, but I would like some pointers on how to connect all the pieces together. |
Nice, maybe let's do a session together tomorrow or Tuesday. |
Closed in favor of #5245 |
Closes #5137 and addresses #5177 (comment)
Not sure if this
ScrollLog
is the best name for it (or simplyLogs
/Log
/Scroll
), but pretty happy that I learned how to use ReactiveHTML-ish~I envision that ChatBox will replace the generic Column with this once this is merged.
Also, I wonder if this should have pagination built-in?
Screen.Recording.2023-07-04.at.9.48.41.PM.mov