Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Vega selection fields #5145

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Allow for Vega selection fields #5145

merged 3 commits into from
Jun 20, 2023

Conversation

philippjfr
Copy link
Member

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #5145 (f63a4f7) into main (3c41978) will decrease coverage by 0.02%.
The diff coverage is 85.13%.

@@            Coverage Diff             @@
##             main    #5145      +/-   ##
==========================================
- Coverage   83.73%   83.71%   -0.02%     
==========================================
  Files         274      274              
  Lines       39414    39488      +74     
==========================================
+ Hits        33003    33059      +56     
- Misses       6411     6429      +18     
Flag Coverage Δ
ui-tests 40.52% <82.43%> (+0.10%) ⬆️
unitexamples-tests 73.68% <20.27%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/vega.py 78.78% <10.00%> (-3.13%) ⬇️
panel/tests/ui/pane/test_vega.py 97.43% <96.87%> (-2.57%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit b226014 into main Jun 20, 2023
@philippjfr philippjfr deleted the vega_agg_select branch June 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse Vega-lite selection using Altair
1 participant